Fix comparison with NoneType logical error #3009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ulincsys <ulincsys@gmail.com>
ABrain7710
reviewed
Feb 21, 2025
| review_msg_url += f"?since={core_data_last_collected.isoformat()}" | ||
| last_collected_date = get_core_data_last_collected(repo_id) | ||
|
|
||
| # the full_collection parameter is hardcoded to False, so we must check if there actually is a last_collected date |
There was a problem hiding this comment.
Where do you see that the full_collection parameter is hardcoded to false?
ABrain7710
requested changes
Feb 22, 2025
Signed-off-by: Ulincsys <ulincsys@gmail.com>
ABrain7710
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Signed commits